Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 1 | Form Controls#1288
Open
SandzSoft wants to merge 4 commits into
Open
Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 1 | Form Controls#1288SandzSoft wants to merge 4 commits into
SandzSoft wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
SandzSoft
changed the title
SandzSoft
added
the
Needs Review
SandzSoft
changed the title
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Looks quiet good. Everything is working as expected. I have some comments on the code formatting
There was a problem hiding this comment.
Nice styling of the form. I like how it looks
Comment on lines
12
to
13
| <div class="container"> | ||
| <header> |
There was a problem hiding this comment.
The standard is to use intendation for children elements to make it easer to understand the html structure.How can you ensure consistent formatting in your code automatically?
Author
There was a problem hiding this comment.
I can ensure consistent formatting automatically by using a code formatter like Prettier in VS Code with “format on save” enabled, so indentation and structure are cleaned automatically every time I save the file.
| this will also help you fill in your PR message later--> | ||
| <div class="field"> | ||
| <label for="customer_name">Name :</label> | ||
| <input minlength="2" required type="text" id="customer_name" name="customer_name"> |
Comment on lines
+51
to
+54
|
|
||
|
|
||
|
|
||
|
|
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
A semantic HTML form
Required name and email validation
T-shirt colour selection
T-shirt size selection
CSS styling using Flexbox layout
Accessibility improvements